Skip to content

Vp migrate test#1

Draft
fengmk2 wants to merge 2 commits into
masterfrom
vp-migrate-test
Draft

Vp migrate test#1
fengmk2 wants to merge 2 commits into
masterfrom
vp-migrate-test

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 30, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates Vite+ as the unified toolchain for the project, replacing standalone oxfmt and oxlint tools. It updates package scripts, pre-commit hooks, VS Code settings, and adds documentation for the new toolchain. The feedback recommends formatting the single-line lint configuration in vite.config.ts into a multi-line object literal to improve readability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread vite.config.ts
"*": "vp check --fix"
},
fmt: {},
lint: {"jsPlugins":[{"name":"vite-plus","specifier":"vite-plus/oxlint-plugin"}],"rules":{"vite-plus/prefer-vite-plus-imports":"error"},"options":{"typeAware":true,"typeCheck":true}},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The lint configuration object is currently written as a single-line JSON-like string, which is difficult to read and maintain. It should be formatted as a standard, multi-line TypeScript object literal.

  lint: {
    jsPlugins: [
      {
        name: 'vite-plus',
        specifier: 'vite-plus/oxlint-plugin'
      }
    ],
    rules: {
      'vite-plus/prefer-vite-plus-imports': 'error'
    },
    options: {
      typeAware: true,
      typeCheck: true
    }
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant