vp migrate beta test#9
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project to use Vite+, updating configuration files, VS Code settings, documentation, and test imports to reference vite-plus instead of standard vite and vitest. Feedback on the changes includes removing the temporary registry bridge in .npmrc and updating the temporary commit-specific dependency versions in pnpm-workspace.yaml to stable releases before merging. Additionally, it is suggested to use any instead of unknown for the third generic parameter in the Vue SFC shim declaration to prevent overly restrictive type-checking.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @@ -0,0 +1,2 @@ | |||
| # pkg.pr.new registry bridge (added by test-pkg-pr-new-migrate.sh) | |||
| registry=https://pkg-pr-registry-bridge.render.vip/ | |||
There was a problem hiding this comment.
This .npmrc file configures a temporary registry bridge (https://pkg-pr-registry-bridge.render.vip/) to resolve commit-specific packages from pkg.pr.new. While this is necessary for testing the migration in this PR, committing this to the main branch is a security and reliability risk. Please ensure this file is removed before merging.
| vite: npm:@voidzero-dev/vite-plus-core@0.0.0-commit.d5c8d9e163733881a841c16ca1778868d65fe7ef | ||
| vite-plus: 0.0.0-commit.d5c8d9e163733881a841c16ca1778868d65fe7ef |
There was a problem hiding this comment.
These dependencies are pinned to temporary commit-specific versions (0.0.0-commit.d5c8d9e163733881a841c16ca1778868d65fe7ef) published via pkg.pr.new. Before merging this pull request, please update these to stable, officially released versions of vite and vite-plus to ensure reproducible and reliable builds.
| @@ -0,0 +1,5 @@ | |||
| declare module '*.vue' { | |||
| import type { DefineComponent } from 'vue'; | |||
| const component: DefineComponent<{}, {}, unknown>; | |||
There was a problem hiding this comment.
Using unknown as the third generic parameter (D / data) for DefineComponent can be overly restrictive and may cause type-checking issues in TypeScript files importing .vue components. It is standard practice to use any or {} for the wildcard SFC shim to ensure compatibility.
| const component: DefineComponent<{}, {}, unknown>; | |
| const component: DefineComponent<{}, {}, any>; |
Align packages/vue-fate/src/env.d.ts with the other Vue shim files by
using Record<string, unknown> instead of {}, which the newer oxlint
toolchain flags via no-empty-object-type.
cf-fate
create-fate
@nkzw/fate
react-fate
void-fate
vue-fate
commit: |
No description provided.