vp migrate beta test#3
Conversation
There was a problem hiding this comment.
Code Review
This pull request configures the workspace to use pnpm catalogs for managing vite, vite-plus, and vitest versions, updates import paths in next-env.d.ts, and adds a registry bridge in .npmrc. Feedback on these changes highlights a conflict in package.json where the overrides block still points to @latest instead of the catalog, which will cause resolution issues. Additionally, it is recommended to add @vitest/coverage-v8 to the catalog to keep its version in sync with vitest, and to use a scoped registry in .npmrc instead of overriding the global registry to avoid routing all package resolutions through the bridge.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "vite": "catalog:", | ||
| "vite-plus": "catalog:", | ||
| "vitest": "catalog:" |
There was a problem hiding this comment.
The overrides block in package.json (lines 118-121) still overrides vite to npm:@voidzero-dev/vite-plus-core@latest and vitest to npm:@voidzero-dev/vite-plus-test@latest. This conflicts with the new "catalog:" configuration and will cause pnpm to resolve these packages to @latest instead of the specific commit-pinned versions defined in pnpm-workspace.yaml. Please remove or update the overrides block in package.json to use "catalog:" (or rely entirely on the overrides defined in pnpm-workspace.yaml).
| "@types/retry": "^0.12.5", | ||
| "@vitejs/plugin-react": "^4.7.0", | ||
| "@vitest/coverage-v8": "^4.1.7", | ||
| "@vitest/coverage-v8": "4.1.9", |
There was a problem hiding this comment.
Since vitest is managed via the pnpm catalog in pnpm-workspace.yaml, it is highly recommended to also add @vitest/coverage-v8 to the catalog to keep their versions in sync and maintainable across the workspace.
| # nodeLinker and publicHoistPattern moved to pnpm-workspace.yaml. | ||
|
|
||
| # pkg.pr.new registry bridge (added by test-pkg-pr-new-migrate.sh) | ||
| registry=https://pkg-pr-registry-bridge.void.app/ |
There was a problem hiding this comment.
Overriding the global registry to https://pkg-pr-registry-bridge.void.app/ routes all package resolutions through this bridge. If this is only intended for @voidzero-dev packages, consider using a scoped registry configuration instead to avoid potential performance or resolution issues for other public packages.
No description provided.