Skip to content

vp migrate beta test#2

Draft
fengmk2 wants to merge 2 commits into
mainfrom
vp-migrate-test
Draft

vp migrate beta test#2
fengmk2 wants to merge 2 commits into
mainfrom
vp-migrate-test

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 28, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures a registry bridge in .npmrc, adds VS Code formatter settings for JS/TS files using OXC, documents the usage of Vite+ in AGENTS.md, and pins specific commit-based versions for vite and vite-plus in pnpm-workspace.yaml. Additionally, it adds a wildcard module declaration for *.vue in env.d.ts. Feedback suggests removing this wildcard declaration because it overrides precise component types generated by vue-tsc/Volar, which disables type-checking for props, slots, and emits.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread env.d.ts
Comment on lines +4 to +8
declare module "*.vue" {
import type { DefineComponent } from "vue";
const component: DefineComponent<{}, {}, unknown>;
export default component;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Declaring a wildcard *.vue module in env.d.ts overrides the precise component types generated by vue-tsc / Volar. This causes all Vue component imports to be typed as a generic DefineComponent<{}, {}, unknown>, which disables type-checking for props, slots, and emits when components are imported (e.g., in App.vue). Since this project uses vue-tsc for type checking, this wildcard declaration is unnecessary and should be removed to maintain full type safety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant