Skip to content

vp migrate beta test#9

Draft
fengmk2 wants to merge 1 commit into
mainfrom
vp-migrate-test
Draft

vp migrate beta test#9
fengmk2 wants to merge 1 commit into
mainfrom
vp-migrate-test

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 29, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures pnpm catalogs to manage dependencies (vite, vite-plus, and vitest) and adds a registry bridge in .npmrc. It also expands the minimumReleaseAgeExclude list in pnpm-workspace.yaml. Feedback is provided regarding a critical issue in pnpm-workspace.yaml where vitest is mapped to version 4.1.9 instead of the custom @voidzero-dev/vite-plus-test package, which will cause installation failures.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pnpm-workspace.yaml
vitest: '*'
catalog:
vite: npm:@voidzero-dev/vite-plus-core@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442
vitest: 4.1.9

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In the previous configuration, vitest was mapped to the custom @voidzero-dev/vite-plus-test package. Setting it to 4.1.9 in the catalog will cause pnpm to resolve it to the standard vitest package (which does not have a version 4.1.9 yet, leading to installation failures), rather than the custom vite-plus-test package. It should be updated to use the custom npm:@voidzero-dev/vite-plus-test package with the corresponding commit hash.

  vitest: npm:@voidzero-dev/vite-plus-test@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant