vp migrate beta test#9
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project to Vite+ and configures pnpm catalogs for dependency management, alongside adding pre-commit hooks, VS Code settings, and documentation. However, there are critical issues to address: the overrides configuration is incorrectly placed in pnpm-workspace.yaml instead of package.json where it belongs, and a temporary .npmrc registry bridge from a migration script was accidentally committed and should be removed.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| overrides: | ||
| vite: "catalog:" | ||
| vitest: "catalog:" | ||
| catalog: |
There was a problem hiding this comment.
In pnpm, the overrides field is not supported as a top-level configuration in pnpm-workspace.yaml. It must be defined in the root package.json under the pnpm.overrides property. Placing it here will cause pnpm to ignore these overrides, which prevents transitive dependencies of vite and vitest from being correctly resolved to the catalog versions.
Please remove this block from pnpm-workspace.yaml and add it back to your root package.json under pnpm.overrides.
catalog:| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.16" | ||
| } | ||
| } | ||
| "packageManager": "pnpm@10.33.0" |
There was a problem hiding this comment.
Since overrides is not supported in pnpm-workspace.yaml, you should define the catalog-based overrides here in the root package.json under the pnpm.overrides field. This ensures that all transitive dependencies of vite and vitest are correctly forced to use the catalog versions.
"packageManager": "pnpm@10.33.0",
"pnpm": {
"overrides": {
"vite": "catalog:",
"vitest": "catalog:"
}
}| # pkg.pr.new registry bridge (added by test-pkg-pr-new-migrate.sh) | ||
| registry=https://pkg-pr-registry-bridge.render.vip/ |
There was a problem hiding this comment.
The custom registry bridge https://pkg-pr-registry-bridge.render.vip/ seems to have been added automatically by a migration test script (test-pkg-pr-new-migrate.sh). Committing this to the repository will force all developers and CI environments to use this temporary registry bridge, which can lead to slow builds, installation failures, or security risks if the bridge is unavailable or compromised.
Please remove .npmrc from the commit or restore the default registry configuration.
No description provided.