vp migrate beta test#1
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the repository's dependency management by introducing a shared catalog for "vite" and "vitest" across various packages and examples, alongside updating "vite-plus" to a specific pre-release version. Additionally, it formats VS Code settings, removes "oxlint-tsgolint", adopts "lazyPlugins" in the core Vite configuration, and updates the testing suite with Playwright browser support. The review feedback suggests improving dependency consistency by using the "catalog:" protocol for "vite-plus" in the workspace overrides and pinning the "playwright" dependency in the test package to a specific version instead of using a wildcard.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "@tiptap/pm": "^3.0.0" | ||
| vite: "catalog:" | ||
| vitest: "catalog:" | ||
| vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@529396f85556c9ae7650dad6b52257b94a1fd0d2 |
There was a problem hiding this comment.
To maintain consistency and avoid duplication, you can use the "catalog:" protocol for vite-plus in the overrides section, just as you did for vite and vitest. This ensures that when the vite-plus version is updated in the catalog section, it automatically propagates to the overrides without needing manual updates in multiple places.
vite-plus: "catalog:"| "vitest-browser-react": "^2.2.0" | ||
| "vitest-browser-react": "^2.2.0", | ||
| "@vitest/browser-playwright": "4.1.9", | ||
| "playwright": "*", |
There was a problem hiding this comment.
To prevent potential version mismatches between the Playwright test runner and the browser drivers, it is highly recommended to pin the playwright dependency to match the version of @playwright/test (which is 1.60.0) instead of using *.
| "playwright": "*", | |
| "playwright": "1.60.0", |
Summary
Rationale
Changes
Impact
Testing
Screenshots/Video
Checklist
Additional Notes