Provide masks DDD and DDDD to print "Yesterday", "Today" or "Tomorrow".#71
Provide masks DDD and DDDD to print "Yesterday", "Today" or "Tomorrow".#71chase-manning merged 12 commits intofelixge:masterfrom
Conversation
TalhaAwan
commented
Jul 16, 2017
- If the date belongs to yesterday, today or tomorrow the masks should print so.
- If the date does not lie in these days then DDD should fall back to ddd and DDDD to dddd.
- Unit tests added
- Readme updated
|
Though tests are passing, the logic is incorrect. I mistakenly used day of week instead of day of month. Even with day of month, boundary conditions on changing months and years will need to be handled. Will try to work on this later. |
|
Fixed with simplified logic. |
|
@TalhaAwan Thanks so much for this PR, is a great idea!!! |
chase-manning
left a comment
There was a problem hiding this comment.
Thanks so much for the PR!!!
I have added some review comments to be resolved.
|
@chase-manning I resolved the readme conflicts only to find out that tests are not passing. Lots have changed since I opened this PR, so I'll have to re-add this functionality. Will do that soon. |
chase-manning
left a comment
There was a problem hiding this comment.
Looks great!!! ❤️
|
@chase-manning "Yes", "Tom" and "Tod" look odd though. Do you think we should change that? I was looking it up and YDA, TDA, and TMW/TMR are the abbreviations that are used in certain fields. Let me know if this needs change. |