Update time zone abbreviations#104
Conversation
|
@matthewbadeau Hi Matthew, thanks so much for the PR!! |
|
@chase-manning Hi there! I went nuclear and just pulled the latest and added the changes I wanted to make. The tests aren't passing but I think it's because the time zone offset is not empty when the tests are run. The test replaces GMT+0000 to UTC but expects GMT. I might be misunderstanding it though. If I have time, I'll try to make another PR with changes to the tests. |
|
Sorry for the multiple comments. The tests are currently passing but it still doesn't fix the issue where 4 character time zones are not being displayed. For example, running Before merging I will investigate more. |
|
@chase-manning is there anything that can be done to move this PR forward? |
@mikegreiling It currently has a merge conflict, once that is fixed we can merge it 😄 |
|
@chase-manning it looks like @milohax created a MR to address the conflicts with #165 |
|
Closing as this was completed in a seperate PR |
Uses list of time zone abbreviations. https://en.wikipedia.org/wiki/List_of_time_zone_abbreviations
I expanded the regular expression to use all time zone abbreviations.
As an example
AESTtime zones are being clipped to justEST. This change fixes that problem. It also fixes unreported problems with other time zones. According to Wikipedia the longest time zone is five characters.