Skip to content

[PARALLEL] Add JSON stream progress writer #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
felixfontein wants to merge 5 commits into from
Closed

[PARALLEL] Add JSON stream progress writer #1

felixfontein wants to merge 5 commits into from

Conversation

@felixfontein
Copy link
Owner

@felixfontein felixfontein commented Feb 8, 2024

Copy of docker#11478 so I can run CI without waiting for someone to approve it.

@felixfontein felixfontein force-pushed the json-progress branch 3 times, most recently from 3fec17c to dea886c Compare February 8, 2024 13:06
@felixfontein felixfontein reopened this Feb 8, 2024
@felixfontein felixfontein mentioned this pull request Feb 8, 2024
Merged
@felixfontein felixfontein force-pushed the json-progress branch 2 times, most recently from 150e636 to 07a29dd Compare February 23, 2024 05:38
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.56410% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 54.27%. Comparing base (4b7b6ad) to head (2f78203).

Files Patch % Lines
pkg/progress/json.go 0.00% 37 Missing ⚠️
cmd/compose/compose.go 0.00% 28 Missing and 1 partial ⚠️
pkg/progress/writer.go 0.00% 6 Missing and 1 partial ⚠️
cmd/compose/build.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main       #1      +/-   ##
==========================================
- Coverage   54.79%   54.27%   -0.52%     
==========================================
  Files         145      146       +1     
  Lines       12593    12670      +77     
==========================================
- Hits         6900     6877      -23     
- Misses       5000     5094      +94     
- Partials      693      699       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixfontein
Add JSON stream progress writer
14e0bbd 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Pass 'plain' instead of 'json' to build backend
b8cdce5 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Format errors as JSON when in JSON progress mode.
1af4987 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Set logging format to JSON.
0d2ed6b 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Use rawjson for the build backend.
2245943 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein deleted the json-progress branch July 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felixfontein @codecov-commenter