Update Prompt API to latest shape#11
Merged
felixarntz merged 4 commits intofelixarntz:mainfrom Oct 10, 2024
Merged
Conversation
felixarntz
reviewed
Oct 9, 2024
Owner
felixarntz
left a comment
There was a problem hiding this comment.
@tomayac Thanks for the PR!
This is all still very early, so haven't verified it yet either, but left some feedback based on the docs.
Co-authored-by: Felix Arntz <flixos90@gmail.com>
Co-authored-by: Felix Arntz <flixos90@gmail.com>
felixarntz
reviewed
Oct 10, 2024
felixarntz
approved these changes
Oct 10, 2024
Owner
felixarntz
left a comment
There was a problem hiding this comment.
Fixed the two formatting issues, LGTM!
Thanks again!
Owner
|
The plugin check error here is unrelated and I believe incorrect, so I'm going to go ahead and merge this. For reference, I opened WordPress/plugin-check#713 upstream. |
Contributor
Author
|
Just to close: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't test this, so please proceed with caution. If it doesn't work, it most likely only fails because of the
modelParams.