Ignore synthetic key Pressed events

akgrant43 · akgrant43 · commit 55656e0ad950 · 2020-06-20T14:42:02.000+02:00
rust-windowing generates synthetic key press and release events to try and work around issues with keys being pressed and held while window focus is lost, see rust-windowing/winit#1296 However the Ubuntu workspace keyboard shortcut (and others) is causing synthetic Pressed events, without the corresponding Release event. Ignoring synthetic key pressed events, in addition to the existing behaviour of releasing all keys when window focus is lost (feenkcom/gtoolkit#423) resolves the issue. Fixes: feenkcom/gtoolkit#1178
diff --git a/src/Glutin/GlutinEventsFetcher.class.st b/src/Glutin/GlutinEventsFetcher.class.st
@@ -173,6 +173,15 @@ GlutinEventsFetcher >> processGlutinEvent: aGlutinEvent [
 	| mappedEvent |
 
 	mappedEvent := aGlutinEvent mapped.
+
+	"rust-windowing generates synthetic key press and release events to try and work around issues with keys being pressed and held while window focus is lost, see https://github.com/rust-windowing/winit/pull/1296
+	However the Ubuntu workspace keyboard shortcut is causing synthetic Pressed events, without the corresponding Release event.
+	Ignore synthetic key Pressed events"
+	(mappedEvent isKeyboardInputEvent  and:
+		[ mappedEvent is_synthetic and:
+		[ mappedEvent state = GlutinEventInputElementState Pressed ] ]) ifTrue:
+				[ ^ self ].
+
 	self eventHandlers do: [ :eachHandler | eachHandler processGlutinEvent: mappedEvent ]
 ]
 
diff --git a/src/Glutin/GlutinKeyboardInputEvent.class.st b/src/Glutin/GlutinKeyboardInputEvent.class.st
@@ -67,6 +67,11 @@ GlutinKeyboardInputEvent >> has_virtual_keycode: anObject [
 	handle booleanAt: OFFSET_HAS_VIRTUAL_KEYCODE put: anObject
 ]
 
+{ #category : #testing }
+GlutinKeyboardInputEvent >> isKeyboardInputEvent [
+	^ true
+]
+
 { #category : #'accessing structure variables' }
 GlutinKeyboardInputEvent >> is_synthetic [
 	"This method was automatically generated"
diff --git a/src/Glutin/GlutinMappedEvent.class.st b/src/Glutin/GlutinMappedEvent.class.st
@@ -29,6 +29,11 @@ GlutinMappedEvent >> isDeviceEvent [
 	^ false
 ]
 
+{ #category : #testing }
+GlutinMappedEvent >> isKeyboardInputEvent [
+	^ false
+]
+
 { #category : #testing }
 GlutinMappedEvent >> isWindowEvent [
 	^ false
