Migrate from LanguageTag to Intl.Locale for representing language tags#392
Migrate from LanguageTag to Intl.Locale for representing language tags#392dahlia merged 7 commits intofedify-dev:nextfrom
LanguageTag to Intl.Locale for representing language tags#392Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @Palcimer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the handling of language tags by replacing a third-party library with JavaScript's built-in Intl.Locale API. This change aims to leverage native browser capabilities for improved performance and better integration, while also reducing external dependencies. The core functionality of representing and processing language-tagged strings remains consistent, but the underlying implementation is now more efficient and standardized.
Highlights
- Core Migration: Migrated the internal representation of language tags from the third-party
@phensley/language-taglibrary to the nativeIntl.LocaleAPI, enhancing performance and compatibility. - Dependency Removal: Eliminated the
@phensley/language-tagdependency from the project, simplifying the dependency tree and reducing bundle size. - API Renaming: Renamed the
languageproperty tolocalewithin theLanguageStringclass to improve clarity and avoid awkward repetition in property access. - ScalarType Update: Updated the
fedify:langTagScalarType to correctly handle and encode/decodeIntl.Localeobjects. - Test Adjustments: Modified existing tests and snapshots to align with the new
Intl.Localeusage and property changes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully migrates from the third-party @phensley/language-tag library to the native Intl.Locale API for handling language tags. This is a positive change that improves performance and reduces dependencies. The implementation is solid, with updates to the core logic, tests, and documentation. I've identified a couple of minor areas for improvement in the documentation and code consistency, but overall, this is a great contribution.
Summary
Migrate from
LanguageTagtoIntl.Localefor representing language tagsRelated Issue
Reference the related issue(s) by number, e.g.:
Intl.Localefor Fedify 2.0 #280Changes
LanguageTagwithIntl.Localein theLanguageStringclass.fedify:langTag)Benefits
Checklist
deno task test-allon your machine?Additional Notes
languagetolocaleto eliminate the awkward repetition in the expressionthis.language.language, and I wonder if the renaming was appropriate.CHANGES.md