Skip to content

Create Issue and Pull Request Templates#302

Closed
w8385 wants to merge 0 commit intofedify-dev:mainfrom
w8385:main
Closed

Create Issue and Pull Request Templates#302
w8385 wants to merge 0 commit intofedify-dev:mainfrom
w8385:main

Conversation

@w8385
Copy link
Contributor

@w8385 w8385 commented Jul 16, 2025

Summary

Create Issue and Pull Request Templates to share context consistently between contributors.

Related Issue

Changes

  • Create issue templates
    • You can check these image files. Issue images.zip
    • Items grouped below shares same format.
      • Feature / Enhancement
      • Refactor / Performance / Test

        For Performance issues, the Benefits section is specifically replaced with Benchmarks.

  • Create PR template
    • You can check right this PR template

    • Used markdown template
      ## Summary
      Briefly describe the main purpose and scope of this PR.
      
      ## Related Issue
      Reference the related issue(s) by number.
      - 
      
      ## Changes
      List the specific modifications made in this PR.
      Focus on *what* was changed without going into detail about impact.
      - 
      
      ## Benefits
      Describe the advantages or improvements brought by these changes.
      Explain how these changes affect the project, users, or performance.
      
      ## Checklist
      - [ ] Did you add a changelog entry to the *CHANGES.md*?
      - [ ] Did you write some relevant docs about this change (if it's a new feature)?
      - [ ] Did you write a regression test to reproduce the bug (if it's a bug fix)?
      - [ ] Did you write some tests for this change (if it's a new feature)?
      - [ ] Did you run `deno task test-all` on your machine?
      
      ## Additional Notes
      Include any other information, context, or considerations.

Benefits

  • Supports better triage and prioritization
    Labeled and structured issues can be filtered and sorted more effectively.

github com_w8385_fedify_issues

  • Encourages consistency
    Contributors follow a shared structure, making issues and PRs easier to read and review.
Example Bug report 1  Bug report

Checklist

  • Did you add a changelog entry to the CHANGES.md?
  • Did you write some relevant docs about this change (if it's a new feature)?
  • Did you write a regression test to reproduce the bug (if it's a bug fix)?
  • Did you write some tests for this change (if it's a new feature)?
  • Did you run deno task test-all on your machine?

Additional Notes

While the initial discussion around issues was based on Markdown formatting, I’ve converted the templates into YAML to improve their visual clarity in the GitHub UI.
If you notice any improvements that could be made—such as adjustments to the required fields—please feel free to share your thoughts!

I hope the new Issue and PR templates will be helpful for all contributors!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @w8385, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a foundational set of GitHub Issue and Pull Request templates for the repository. The primary objective is to streamline the contribution process by providing clear, structured formats for reporting issues and submitting code changes, thereby enhancing communication and maintainability.

Highlights

  • Standardized Issue Templates: Introduced a comprehensive set of GitHub Issue Templates in YAML format, covering various categories such as Bug Report, Chore, Documentation, Enhancement, Feature, Performance, Refactor, and Test. Each template is designed with specific fields to guide contributors in providing structured and complete information.
  • Standardized Pull Request Template: Added a new Markdown-based Pull Request Template to ensure consistency in PR submissions. This template includes sections for summary, related issues, changes, benefits, a checklist, and additional notes.
  • Improved Workflow: The new templates aim to support better issue triage and prioritization, encourage consistency in contributions, and make issues and PRs easier to read and review for all contributors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added component/integration Web framework integration priority/medium Medium priority issues type/documentation Improvements or additions to documentation labels Jul 16, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces issue and pull request templates to standardize contributions and improve context sharing. Suggestions have been provided to enhance their effectiveness, such as making certain fields required and improving the pull request template.

@w8385
Copy link
Contributor Author

w8385 commented Jul 16, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces issue and pull request templates to improve consistency and clarity of contributions. The templates are well-structured and cover a wide range of scenarios.

Comment on lines +10 to +11

[//]: # (- fixes #456)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are those [//]: for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Markdown comment intended to prevent unrelated example issues from being unintentionally linked when the contributor has not modified this section of the PR.

Most contributors won't have permission to link issues directly, so it's fine to just display this as plain text instead of using real references.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

- Fixes #XXX

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reflected in 9f4c8ba

Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase your commits on the current main branch? It would make your pull request pass the CI builds.

@dahlia
Copy link
Member

dahlia commented Jul 17, 2025

Why did you close it?

@w8385
Copy link
Contributor Author

w8385 commented Jul 17, 2025

Why did you close it?

While attempting a reset > pull > rebase workflow, this PR seems to have been accidentally closed.

This happened because I lack experience and knowledge about rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/integration Web framework integration priority/medium Medium priority issues type/documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants