Modernize test autoloading for a more PHP-native configuration#3
Modernize test autoloading for a more PHP-native configuration#3fahad19 merged 2 commits intofeaturevisor:mainfrom
Conversation
|
this is amazing, @Greg0! excellent piece of work. I was always worried about SDKs in new languages being idiomatic enough or not, and you stepped in at a very crucial moment. could you kindly merge latest if the tests are passing, I will merge and do a new incremental release right after. many thanks for taking care of this! ❤️ |
|
@Greg0: thanks for updating this PR. I see that PHP's own tests are passing, but when Featurevisor project's tests are run against the PHP SDK, it's failing here: https://github.com/featurevisor/featurevisor-php/actions/runs/17013976017/job/48234173010?pr=3#step:8:1 to help clarify things a bit more (apologies if you are fully aware of it already):
The expectation is, the test runner should continue to work and pass example-1 project's specs successfully as we continue with this refactoring. |
|
Thanks for pointing that issues. I will take a look at it soon. |
|
@fahad19 Please try again to run example-1 tests |
|
@Greg0: all passing. amazing stuff! will wait for your green light before merging and releasing. |
|
Yes, I don't have anything more in that batch of changes. PR #4 will have conflicts, so some adjustments will be needed |
|
merged, and landed in v0.2.0: https://github.com/featurevisor/featurevisor-php/releases/tag/v0.2.0 welcome to the club of Featurevisor contributors, @Greg0! 🙌 regarding versioning, since we are still in v0.x, it's allowed in semantic versioning to still go for some breaking changes until we hit v1.0 stable. |
Summary
What’s changed (high level)
Why
Follow-ups I plan
This is the first of several PRs aimed at giving the library a more PHP-native feel while preserving existing behavior where possible.