Skip to content

[bugfix] Murmur3 hash seeds should be zero#1111

Merged
rvowles merged 2 commits intomainfrom
bugfix/murmur3
Jan 26, 2024
Merged

[bugfix] Murmur3 hash seeds should be zero#1111
rvowles merged 2 commits intomainfrom
bugfix/murmur3

Conversation

@rvowles
Copy link
Copy Markdown
Contributor

@rvowles rvowles commented Jan 25, 2024

Description

The murmur3 hash should be zero always to match what the SDKs are expected to do. Comparisons against the javascript sdk added here.

Fixes #1109

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

The murmur3 hash should be zero always to match what the SDKs
are expected to do. Comparisons against the javascript sdk
added here.

Fixes #1109
@github-actions github-actions bot added the bug Something isn't working label Jan 25, 2024
@rvowles
Copy link
Copy Markdown
Contributor Author

rvowles commented Jan 26, 2024

/e2e-build

@rvowles rvowles merged commit 673b205 into main Jan 26, 2024
@rvowles rvowles deleted the bugfix/murmur3 branch January 26, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-deterministic hash seed

1 participant