fix: Fix lineage entity filtering (#5321)

franciscojavierarceo · devin-ai-integration[bot] · web-flow · commit 0d05701d2dda · 2025-05-04T21:38:48.000-04:00
* Fix: Entity filtering and permissions in the Lineage tab

Co-Authored-By: Francisco Javier Arceo &lt;arceofrancisco@gmail.com&gt;

* Update PR to clarify fix scope

Co-Authored-By: Francisco Javier Arceo &lt;arceofrancisco@gmail.com&gt;

* Remove entity filtering from Feature View Lineage tab

Co-Authored-By: Francisco Javier Arceo &lt;arceofrancisco@gmail.com&gt;

---------

Co-authored-by: Devin AI &lt;158243242+devin-ai-integration[bot]@users.noreply.github.com&gt;
diff --git a/ui/src/pages/feature-views/FeatureViewLineageTab.tsx b/ui/src/pages/feature-views/FeatureViewLineageTab.tsx
@@ -1,11 +1,20 @@
-import React, { useContext } from "react";
+import React, { useContext, useState } from "react";
 import { useParams } from "react-router-dom";
-import { EuiEmptyPrompt, EuiLoadingSpinner } from "@elastic/eui";
+import {
+  EuiEmptyPrompt,
+  EuiLoadingSpinner,
+  EuiSpacer,
+  EuiSelect,
+  EuiFormRow,
+  EuiFlexGroup,
+  EuiFlexItem,
+} from "@elastic/eui";
 import { feast } from "../../protos";
 import useLoadRegistry from "../../queries/useLoadRegistry";
 import RegistryPathContext from "../../contexts/RegistryPathContext";
 import RegistryVisualization from "../../components/RegistryVisualization";
 import { FEAST_FCO_TYPES } from "../../parsers/types";
+import { filterPermissionsByAction } from "../../utils/permissionUtils";
 
 interface FeatureViewLineageTabProps {
   data: feast.core.IFeatureView;
@@ -20,6 +29,7 @@ const FeatureViewLineageTab = ({ data }: FeatureViewLineageTabProps) => {
     data: registryData,
   } = useLoadRegistry(registryUrl);
   const { featureViewName } = useParams();
+  const [selectedPermissionAction, setSelectedPermissionAction] = useState("");
 
   const filterNode = {
     type: FEAST_FCO_TYPES.featureView,
@@ -47,12 +57,45 @@ const FeatureViewLineageTab = ({ data }: FeatureViewLineageTabProps) => {
         />
       )}
       {isSuccess && registryData && (
-        <RegistryVisualization
-          registryData={registryData.objects}
-          relationships={registryData.relationships}
-          indirectRelationships={registryData.indirectRelationships}
-          filterNode={filterNode}
-        />
+        <>
+          <EuiSpacer size="l" />
+          <EuiFlexGroup style={{ marginBottom: 16 }}>
+            <EuiFlexItem grow={false} style={{ width: 300 }}>
+              <EuiFormRow label="Filter by permissions">
+                <EuiSelect
+                  options={[
+                    { value: "", text: "All" },
+                    { value: "CREATE", text: "CREATE" },
+                    { value: "DESCRIBE", text: "DESCRIBE" },
+                    { value: "UPDATE", text: "UPDATE" },
+                    { value: "DELETE", text: "DELETE" },
+                    { value: "READ_ONLINE", text: "READ_ONLINE" },
+                    { value: "READ_OFFLINE", text: "READ_OFFLINE" },
+                    { value: "WRITE_ONLINE", text: "WRITE_ONLINE" },
+                    { value: "WRITE_OFFLINE", text: "WRITE_OFFLINE" },
+                  ]}
+                  value={selectedPermissionAction}
+                  onChange={(e) => setSelectedPermissionAction(e.target.value)}
+                  aria-label="Filter by permissions"
+                />
+              </EuiFormRow>
+            </EuiFlexItem>
+          </EuiFlexGroup>
+          <RegistryVisualization
+            registryData={registryData.objects}
+            relationships={registryData.relationships}
+            indirectRelationships={registryData.indirectRelationships}
+            permissions={
+              selectedPermissionAction
+                ? filterPermissionsByAction(
+                    registryData.permissions,
+                    selectedPermissionAction,
+                  )
+                : registryData.permissions
+            }
+            filterNode={filterNode}
+          />
+        </>
       )}
     </>
   );
