fix(audio): sound volume initialization & MiniAudio doc updates#171
Merged
Conversation
Set initial gain/volume for both OpenAL and MiniAudio managers on sound/stream creation and looping to prevent audio from defaulting to maximum volume. Fixes #163
Replace references to OpenAL with MiniAudio across project instructions, agent descriptions, and prompts to correctly reflect MiniAudio as the standard/default audio system for GeneralsX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #163
This PR resolves the issue where sound, music, and speech volume options were ignored on playback/loop initialization under both the OpenAL and MiniAudio backends. It also updates project documentation to align with MiniAudio being the standard default audio backend.
Changes
Audio Code Fixes
OpenALAudioManager.cpp): InitializesAL_GAINby callingadjustPlayingVolumeright before starting source playback inplaySample,playSample3D, andplayStream.MiniAudioManager.cpp): Replaces manual/partial volume settings inplayAudioEventandstartNextLoopwith unified calls toadjustPlayingVolume, ensuring both category levels andvolumeShiftpitch/volume variations are applied consistently right at start.Documentation Updates
.github/markdown instruction files to reflect MiniAudio as the standard audio backend.