fix(input): resolve macOS group binding issue and SagePatch snap conflict#164
Merged
Conversation
Owner
Author
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves the group binding issue on macOS where standard shortcuts like
Command + [1..9]were not functioning for group selection/binding, and resolves a window-snapping shortcut collision with SagePatch.Closes #161
Changes
SDL_SCANCODE_LGUIandSDL_SCANCODE_RGUI(Command keys) toKEY_LCTRLandKEY_RCTRLinternally in both base game and Zero Hour keyboard device drivers.Commandmodifier on macOS andControlon other platforms, and added a mandatory check for theAlt(Option/Alt) key. Window snapping now requiresCommand + Option + [1..5]on macOS andControl + Alt + [1..5]on Linux, preventing it from intercepting standard group binding shortcuts.