Skip to content

chore: sync with thesuperhackers/main upstream#162

Merged
fbraz3 merged 14 commits into
mainfrom
thesuperhackers-sync-06-16-2026
Jun 18, 2026
Merged

chore: sync with thesuperhackers/main upstream#162
fbraz3 merged 14 commits into
mainfrom
thesuperhackers-sync-06-16-2026

Conversation

@fbraz3

@fbraz3 fbraz3 commented Jun 16, 2026

Copy link
Copy Markdown
Owner

Description

This Pull Request performs an upstream sync from TheSuperHackers into GeneralsX (main branch) to import useful upstream bug fixes, performance improvements, and stability work while retaining the modern cross-platform codebase architecture (SDL3 + DXVK + OpenAL + FFmpeg).

Key Merged Changes

  • Zero Hour Message Translators Merge: Integrated consolidated game message translators.
  • Pathfinder Optimizations: Integrated spiral cell search improvements and redundant path-exists check skips in checkForAdjust().
  • 16-Bit Index Buffer Crash Fix: Handled dynamic index buffer limit splits to prevent crashes on large army rendering batches in the sorting renderer.
  • VC6 Compiler Compatibility Support: Restructured BitFlags hex formatting using #ifdef _MSC_VER to support standard %llX on GCC/Clang on macOS/Linux while keeping %I64X on MSVC.

Fixes & Adjustments

  • Generals Base Game Compile Fix: Removed MSG_SABOTAGE_HINT from HintSpy.cpp in the base game codebase since it was causing compilation errors due to it being Zero Hour-specific.

Verification

  • Both z_generals (Zero Hour) and g_generals (base game) targets configured and compiled successfully on macOS with the macos-vulkan preset.

stephanmeesters and others added 14 commits June 11, 2026 20:42
Merge upstream changes including Pathfinder optimizations, Zero Hour message translators merge, and sorting renderer 16-bit index limit fix. Reconcile %I64X vs %llX format specifiers in BitFlags.h to prevent compiler warnings on macOS/Linux under GCC/Clang.
…h Alternate Mouse (TheSuperHackers#2798)

Toggle with UseRightMouseScrollWithAlternateMouse=yes/no in Options.ini
Merge upstream changes including CommandXlat and AcademyStats unification into Core, and implementing right mouse scroll toggle for alternate mouse. Wrap Zero Hour-specific CommandXlat cases in base game with RTS_ZEROHOUR checks to prevent compilation errors.
Integrate fog of war, black infantry, and building shadows fixes
from commit 91d8e27 into thesuperhackers sync branch.

Resolved LookAtXlat.cpp conflict by keeping upstream RMB scroll
option (PR TheSuperHackers#2798) over older code without this feature.
…true

Default m_useRightMouseScrollWithAlternateMouse to TRUE in both Generals and Zero Hour to allow right-click drag scrolling under alternate controls by default.
@fbraz3 fbraz3 merged commit d8cc47f into main Jun 18, 2026
8 checks passed
@fbraz3 fbraz3 deleted the thesuperhackers-sync-06-16-2026 branch June 18, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants