cleanup: remove GX-ISSUE144 diagnostic logging#160
Merged
Conversation
Remove all [GX-ISSUE144] tagged stderr instrumentation added during issue #144 investigation. 55 log statements removed across 8 files. Where removing a log left an empty if/else block, the entire block was removed. Unused log_buffer variables and single-use debug flags (_fetchLogged, _constructDrawLogged) were also cleaned up. Files changed: - W3DGameFont.cpp (LoadUnicodeFallbackFont, loadFontData) - InGameUI.cpp (init) - GameWindowManager.cpp (winCreate, assignDefaultGadgetLook) - ControlBarPopupDescription.cpp (show/repopulate/populateBuildTooltipLayout) - ControlBarUnderConstruction.cpp (updateConstructionTextDisplay) - Drawable.cpp (ResolveDrawableCaptionFont, ctor, drawConstructPercent, setCaptionText) - render2dsentence.cpp (Get_Char_Data, Init_FreeType, Store_Freetype_Char) - GlobalLanguage.cpp (init) Builds verified: GeneralsXZH + GeneralsX (macos-vulkan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove all
[GX-ISSUE144]diagnostic stderr logging that was added during issue #144 investigation. The instrumentation served its purpose but pollutes the log in production builds.Changes
if/elseblocks left by log removal were also cleaned uplog_buffervariables and single-use debug flags (_fetchLogged,_constructDrawLogged) removedFiles
W3DGameFont.cppLoadUnicodeFallbackFont,loadFontDataInGameUI.cppinitGameWindowManager.cppwinCreate,assignDefaultGadgetLookControlBarPopupDescription.cppshowBuildTooltipLayout,repopulateBuildTooltipLayout,populateBuildTooltipLayoutControlBarUnderConstruction.cppupdateConstructionTextDisplayDrawable.cppResolveDrawableCaptionFont, ctor,drawConstructPercent,setCaptionTextrender2dsentence.cppGet_Char_Data,Init_FreeType,Store_Freetype_CharGlobalLanguage.cppinitVerification
grep GX-ISSUE144returns 0 hits in source code (1 in DEV_BLOG docs only)