Skip to content

Fix update checker release guard without GitTag#126

Merged
fbraz3 merged 1 commit into
mainfrom
fix/update-checker-release-guard
May 7, 2026
Merged

Fix update checker release guard without GitTag#126
fbraz3 merged 1 commit into
mainfrom
fix/update-checker-release-guard

Conversation

@fbraz3

@fbraz3 fbraz3 commented May 7, 2026

Copy link
Copy Markdown
Owner

Summary

Adjusts the in-game update checker to work on clean release artifacts even when GitTag is empty, while keeping safeguards for dirty builds.

What changed

  • Accept clean builds with either:
    • non-empty GitTag, or
    • valid GitCommitTimeStamp.
  • Keep blocking update checks for dirty builds (GitUncommittedChanges).
  • Use published_at vs local GitCommitTimeStamp when available.
  • Fall back to tag comparison only when a local GitTag exists.
  • Update header comments to reflect the new release eligibility rule.

Validation

  • Compared with functional branch state (hotfix/update-checker-beta-5) for:
    • Core/GameEngine/Source/Common/UpdateChecker.cpp
    • Core/GameEngine/Include/Common/UpdateChecker.h
  • Local runtime behavior confirmed as functional.

Scope

  • Update-checker behavior only.
  • No gameplay logic changes.

@fbraz3 fbraz3 merged commit 02a7642 into main May 7, 2026
12 checks passed
@fbraz3 fbraz3 deleted the fix/update-checker-release-guard branch May 7, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant