fix(macos-build): detect vcpkg root automatically#122
Merged
Conversation
Handle missing or invalid VCPKG_ROOT in macOS build entry scripts by auto-detecting common vcpkg install paths (including Homebrew). This prevents configure failures that resolve to '/scripts/buildsystems/vcpkg.cmake' when the environment variable is unset, and provides actionable guidance when detection fails. Related-to #120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VCPKG_ROOTresolution to macOS build entry scripts/opt, Homebrew)Why
A user report in Discussion #120 showed configure failing with:
Could not find toolchain file: /scripts/buildsystems/vcpkg.cmakeThis happens when
VCPKG_ROOTis unset/invalid and the preset inheritsdefault-vcpkg.Validation
bash -n scripts/build/macos/build-macos-zh.shbash -n scripts/build/macos/build-macos-generals.shVCPKG_ROOT=/invalid/path ./scripts/build/macos/build-macos-zh.sh --build-onlyRelated-to #120