fix(map-cache): support custom map paths and names#114
Merged
Conversation
Handle user custom maps on macOS with separator-agnostic map scanning and cache parsing, and harden quoted-printable ASCII handling for special-character map names.\n\nAlso updates April dev blog and lessons learned with the investigation, stress-test notes, and validation details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes custom user map loading on macOS for maps stored under
~/Library/Application Support/GeneralsX/GeneralsZH/Maps, including maps with special characters in folder/file names and maps that rely on localmap.strmetadata.What Changed
\\and/) in shared map scanning and layout checks.map.strpath derivation to use the real map filepath context.INIMapCache.cpppaths.QuotedPrintableASCII encoding to use locale-independent ASCII checks for predictable special-character handling.Files
Core/GameEngine/Source/GameClient/MapUtil.cppGeneralsMD/Code/GameEngine/Source/Common/INI/INIMapCache.cppGenerals/Code/GameEngine/Source/Common/INI/INIMapCache.cppGeneralsMD/Code/GameEngine/Source/Common/System/QuotedPrintable.cppGenerals/Code/GameEngine/Source/Common/System/QuotedPrintable.cppValidation
Docs
docs/DEV_BLOG/2026-04-DIARY.md.docs/WORKDIR/lessons/2026-04-LESSONS.md.