Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a streaming regression introduced in version 7.0.0 of htmlparser2. The regression prevented entities from being decoded when input was provided incrementally across multiple chunks, which broke streaming use cases.
Changes:
- Refactored entity decoding logic to support incremental processing of multi-character entity runs
- Added comprehensive streaming tests to prevent future regressions
- Updated import paths in code generation script to reflect internal module organization
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/decode.ts | Added runConsumed state variable and refactored compact run decoding logic to support character-by-character streaming |
| src/decode-stream.spec.ts | New comprehensive test suite covering various streaming scenarios including char-by-char and chunked entity decoding |
| scripts/write-decode-map.ts | Updated import path to reference decode-shared.js from correct internal directory location |
| .gitignore | Added .tshy-build/ directory to ignore build artifacts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7.0.0 brought a regression to streaming support (see fb55/htmlparser2#2215). This PR addresses these issues.