Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the encode trie file size by replacing the previous object-based serialization with a compact string format, achieving a 44% reduction in bundle size (from 24,034 to 13,392 bytes).
- Introduces a new string-based serialization format using delta encoding for trie structure
- Replaces object property names (
v,n,o) with descriptive names (value,next,nextValue) - Implements a parser to reconstruct the trie from the compact string representation
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/internal/encode-shared.ts | Adds the new EncodeTrieNode type and parseEncodeTrie function for string-based trie parsing |
| src/encode.ts | Updates property access to use descriptive names instead of abbreviated ones |
| scripts/write-encode-map.ts | Replaces trie serialization logic with new string-based format generation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encodes the encode trie as a string, with a simple parser turning it into the previous structure on load. This leads to a 44% decrease in file size (from 24,034 to 13,392 bytes).