Add getElementsByClassName function to legacy.ts#1551
Merged
fb55 merged 3 commits intofb55:masterfrom Dec 23, 2024
Merged
Conversation
Owner
|
Hi @censujiang, thanks for the contribution! Could you add a simple test case to the legacy spec? |
|
will it be possible with this function get elements with multiple classes? using getElement() with options = {'class': 'className'} doesnt work fine now if the element has more than one class |
Owner
The easiest way to do this would be to use css-select, or to supply a custom function that checks if there is match for the class. |
Owner
|
Thanks @censujiang! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.