fix(manipulation): removeChildren does not correctly de-reference#1271
Closed
dertheodor wants to merge 1 commit intofb55:masterfrom
Closed
fix(manipulation): removeChildren does not correctly de-reference#1271dertheodor wants to merge 1 commit intofb55:masterfrom
dertheodor wants to merge 1 commit intofb55:masterfrom
Conversation
…lings and parent of removed element
Author
|
hey there @fb55, could you please review the pull request? we would be thankful if this bug could be addressed @ |
Owner
|
Hi @dertheodor, tests never ran on this PR. I wanted to rebase it just now to have tests run, but don't have write access to your branch. GitHub usually provides write access for maintainers of the original repo by default, please don't opt out of this if you can, it makes a maintainer's life much easer. Instead, I had to re-create this PR as #1350. |
Owner
|
I've gone ahead and merged the re-created PR. Thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When removing an element via removeElement, the references stay. This is problematic because, when the removed element is appended somewhere else, the last child of the previously removed elements parents gets also removed from the children list.
The test case shows this exact scenario.