Skip to content

Conversation

@hgalytoby
Copy link
Contributor

Description

Add example for medium/large projects in FastAPI.

@hgalytoby
Copy link
Contributor Author

#581 (comment)

@hgalytoby hgalytoby mentioned this pull request Dec 28, 2023
@wbarnha
Copy link
Member

wbarnha commented Dec 28, 2023

Wow, thanks for the PR! I appreciate the example. I'm away from a computer right now but I automatically approve anything that we don't have existing documentation for, so I'm all for getting this merged in.

@codecov
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3812158) 93.55% compared to head (9a841fa) 93.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
+ Coverage   93.55%   93.73%   +0.18%     
==========================================
  Files         102      102              
  Lines       11210    11158      -52     
  Branches     1552     1536      -16     
==========================================
- Hits        10487    10459      -28     
+ Misses        631      612      -19     
+ Partials       92       87       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wbarnha wbarnha merged commit 6588a97 into faust-streaming:master Dec 28, 2023
@hgalytoby hgalytoby deleted the add_fastapi_example branch December 28, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants