Skip to content

fix: fix initial freeze on Docker#91

Merged
fathyb merged 1 commit into
mainfrom
fix-docker-freeze
Feb 9, 2023
Merged

fix: fix initial freeze on Docker#91
fathyb merged 1 commit into
mainfrom
fix-docker-freeze

Conversation

@fathyb

@fathyb fathyb commented Feb 9, 2023

Copy link
Copy Markdown
Owner

No description provided.

@fathyb fathyb merged commit 1d62f24 into main Feb 9, 2023
@fathyb fathyb deleted the fix-docker-freeze branch February 9, 2023 06:05
jmagly pushed a commit to jmagly/carbonyl that referenced this pull request May 22, 2026
DumpTextHandler now observes DidFinishNavigation and exits 6 with empty stdout when the latest primary-frame navigation was a chromium error page or had a non-OK net::Error code. Previously, unreachable URLs exited 0 with empty stdout because chromium loads its internal error page as a real document and our handler extracted its empty body.

Verified against runtime-f6d15927b1241217:
  - https://example.com → exit 0, 130 bytes (regression check)
  - http://10.255.255.1:1/never → exit 6, empty stdout, logs net::ERR_UNSAFE_PORT
  - https://invalid.invalid/ → exit 6, empty stdout, logs net::ERR_NAME_NOT_RESOLVED

Known cosmetic: stderr log says net::net::ERR_* (double net:: prefix because ErrorToString already prefixes). Trivial fix; not worth a rebuild cycle.

HTTP error status codes (404, 500) are NOT treated as nav failures — those are real HTML served by the server.

Closes fathyb#91
Refs fathyb#88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant