fix: fix initial freeze on Docker#91
Merged
Merged
Conversation
jmagly
pushed a commit
to jmagly/carbonyl
that referenced
this pull request
May 22, 2026
DumpTextHandler now observes DidFinishNavigation and exits 6 with empty stdout when the latest primary-frame navigation was a chromium error page or had a non-OK net::Error code. Previously, unreachable URLs exited 0 with empty stdout because chromium loads its internal error page as a real document and our handler extracted its empty body. Verified against runtime-f6d15927b1241217: - https://example.com → exit 0, 130 bytes (regression check) - http://10.255.255.1:1/never → exit 6, empty stdout, logs net::ERR_UNSAFE_PORT - https://invalid.invalid/ → exit 6, empty stdout, logs net::ERR_NAME_NOT_RESOLVED Known cosmetic: stderr log says net::net::ERR_* (double net:: prefix because ErrorToString already prefixes). Trivial fix; not worth a rebuild cycle. HTTP error status codes (404, 500) are NOT treated as nav failures — those are real HTML served by the server. Closes fathyb#91 Refs fathyb#88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.