fix(build): do not use tags for checkout#64
Merged
Conversation
Owner
|
Thank you! |
jmagly
added a commit
to jmagly/carbonyl
that referenced
this pull request
Apr 28, 2026
Both scripts already honoured CARBONYL_OZONE_TAG (added in 5e306d5), but consumers needed a self-describing CLI surface — the env var was easy to forget and easy to set in the wrong shell. Now: scripts/runtime-pull.sh --ozone=x11 scripts/runtime-push.sh --ozone=x11 The CLI flag wins over the env var when both are set; passing the env var still works (CI uses it). Default ozone is "headless" so existing invocations are unchanged. Also adds: - -h/--help on both scripts that prints the in-file usage block - Unknown-flag handling that exits 2 with a clear error - Tag-shape rule comment in both scripts so they stay symmetric - docs/runtime-modes.md: new "Fetching a runtime tarball" section that prefers the CLI flag over the env var for operator workflows Closes fathyb#64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When chromium source is fetched with extra params
--no-history, there will be no tag info in the local.gitrepository, and./scripts/pacthes.sh applywill fail becausegit push --set-upstream origin fix-for-patchesfails, so use the commit hash instead.