build: various build system fixes#20
Merged
Merged
Conversation
Closed
the-homeless-god
pushed a commit
to the-homeless-god/wb
that referenced
this pull request
Dec 5, 2023
jmagly
added a commit
to jmagly/carbonyl
that referenced
this pull request
Apr 9, 2026
Adds patch 0023 (Path B build fixes per fathyb#27). Carbonyl now builds cleanly on M135. headless_shell links and binary runs. The b64 text-capture mode (--carbonyl-b64-text) is disabled in this build because its blink/renderer/core reach triggers an Oilpan/cppgc cascade in M135. Bitmap rendering (the default) is unaffected. Path A (fathyb#28) restores the feature via a real blink TU and is the structural fix that gates all rebases past M135. Closes fathyb#27. Refs: fathyb#20, fathyb#28, fathyb#29, fathyb#30. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jmagly
added a commit
to jmagly/carbonyl
that referenced
this pull request
Apr 9, 2026
- changelog.md: M135 marked as SHIPPED with patch 0022/0023 details,
full b64 text capture removal note, runtime tarball link, CI section
- readme.md: bump from "M120, M135 in progress" to "M135 shipped",
add carbonyl-agent reference, document b64 text limitation
- MAINTENANCE.md: 23-patch breakdown, Path B/Path A explanation,
M135 GN args quirks (left at platform defaults)
- src/browser/host_display_client.{cc,h}: drop dead X11 path
(ozone_platform_x11 = false in this build) — found during M135 build
triage; removes a buildflag include cascade
Refs: fathyb#20 fathyb#27 fathyb#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17