Skip to content

build: various build system fixes#20

Merged
fathyb merged 3 commits into
mainfrom
fix-patches
Jan 29, 2023
Merged

build: various build system fixes#20
fathyb merged 3 commits into
mainfrom
fix-patches

Conversation

@fathyb

@fathyb fathyb commented Jan 29, 2023

Copy link
Copy Markdown
Owner

Fixes #17

@fathyb fathyb merged commit f43e023 into main Jan 29, 2023
@fathyb fathyb deleted the fix-patches branch January 29, 2023 21:07
@fathyb fathyb mentioned this pull request Jan 29, 2023
the-homeless-god pushed a commit to the-homeless-god/wb that referenced this pull request Dec 5, 2023
jmagly added a commit to jmagly/carbonyl that referenced this pull request Apr 9, 2026
Adds patch 0023 (Path B build fixes per fathyb#27). Carbonyl now builds
cleanly on M135. headless_shell links and binary runs.

The b64 text-capture mode (--carbonyl-b64-text) is disabled in this
build because its blink/renderer/core reach triggers an Oilpan/cppgc
cascade in M135. Bitmap rendering (the default) is unaffected. Path A
(fathyb#28) restores the feature via a real blink TU and is the structural
fix that gates all rebases past M135.

Closes fathyb#27.
Refs: fathyb#20, fathyb#28, fathyb#29, fathyb#30.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jmagly added a commit to jmagly/carbonyl that referenced this pull request Apr 9, 2026
- changelog.md: M135 marked as SHIPPED with patch 0022/0023 details,
  full b64 text capture removal note, runtime tarball link, CI section
- readme.md: bump from "M120, M135 in progress" to "M135 shipped",
  add carbonyl-agent reference, document b64 text limitation
- MAINTENANCE.md: 23-patch breakdown, Path B/Path A explanation,
  M135 GN args quirks (left at platform defaults)
- src/browser/host_display_client.{cc,h}: drop dead X11 path
  (ozone_platform_x11 = false in this build) — found during M135 build
  triage; removes a buildflag include cascade

Refs: fathyb#20 fathyb#27 fathyb#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to build on Ubuntu?

1 participant