Closes fathyb#28. See fathyb#27 for the diagnosis this structurally resolves. Adds src/blink/ (symlinked into the chromium tree at chromium/src/carbonyl/src/blink/) containing a new source_set //carbonyl/src/blink:text_capture that's compiled with INSIDE_BLINK: src/blink/BUILD.gn — new GN source_set with inside_blink config src/blink/text_capture.h — public entry point, no blink/renderer/* reach src/blink/text_capture.cc — TextCaptureDevice + RendererService moved verbatim from patch 0010's inline definitions And patch 0024 which wires everything together: - content/renderer/render_frame_impl.cc drops all blink/renderer/* and blink/renderer/platform/graphics/paint/* includes - render_frame_impl.cc drops the TextCaptureDevice + RendererService class definitions (~200 lines) — they're in the new TU now - render_callback_ lambda replaced with a thin call into the new carbonyl::text_capture::CaptureFromFrame() entry point - Visibility entries added to the three blink GN targets that //carbonyl/src/blink:text_capture depends on: //third_party/blink/renderer:inside_blink //third_party/blink/renderer/core:core //third_party/blink/renderer/platform:platform - content/renderer/BUILD.gn deps updated Also: fix M135 -Wunsafe-buffer-usage in text_capture.cc by replacing raw char[] indexing with std::string::push_back in the base64 decode loop. After this patch: - Zero blink/renderer/* includes in any non-blink TU patched by carbonyl (audit script cross-checks this: Category A = 0) - The Oilpan/cppgc cascade documented in fathyb#27 can no longer fire - --carbonyl-b64-text mode works again on M135 - All carbonyl rebases past M135 are unblocked - M135 build still green (same binary, same runtime tarball hash) Refs: fathyb#16 (M111→M135 epic), fathyb#27, fathyb#28, fathyb#29. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Uh oh!

visible chrome://chrome-urls sites? #16

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions