adding functionality to gridplot to name subplots in gridplot #27
Conversation
|
I thought about this a bit more and it makes more sense for
more comments in the code |
|
Add |
|
naming functionality now works as outlined in #36 take a look and let me know if I need to make any additional changes, or could improve elegancy!! |
|
can you do this without the heatmap branch being merged into here? that branch Is too rudimentary and I want to merge this first |
|
still need to implement helpful |
|
Can you update the example notebooks according to this PR |
fastplotlib/layouts.py
Outdated
| for subplot in self._subplots.ravel(): | ||
| if subplot.name == index: | ||
| return subplot | ||
| else: |
There was a problem hiding this comment.
nope this will always raise after the first iteration, you need just a raise after the loop
|
great job on your first contribution! :D |
addressing some of the simplification ideas in #22 , #36
basically adds the ability to name subplots in a gridplot