Skip to content

[CDTOOL- 1216] Support for NGWAF Alerts #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rcaril merged 20 commits into from
Dec 8, 2025
Merged

[CDTOOL- 1216] Support for NGWAF Alerts #1589

rcaril merged 20 commits into from
Dec 8, 2025

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Nov 25, 2025 •
edited
Loading

Change summary

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@rcaril
Copy link
Contributor Author

rcaril commented Dec 1, 2025

Tests

// Datadog
make test TEST_ARGS="-run TestDatadogAlertCreate ./pkg/commands/ngwaf/workspace/alert/datadog"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/datadog        1.060s
 make test TEST_ARGS="-run TestDatadogAlertList ./pkg/commands/ngwaf/workspace/alert/datadog" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/datadog        1.057s
 make test TEST_ARGS="-run TestDatadogAlertGet ./pkg/commands/ngwaf/workspace/alert/datadog" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/datadog        1.062s
make test TEST_ARGS="-run TestDatadogAlertUpdate ./pkg/commands/ngwaf/workspace/alert/datadog" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/datadog        1.060s
 make test TEST_ARGS="-run TestDatadogAlertDelete ./pkg/commands/ngwaf/workspace/alert/datadog" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/datadog        1.058s

// Jira
make test TEST_ARGS="-run TestJiraAlertCreate ./pkg/commands/ngwaf/workspace/alert/jira" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/jira   1.094s
make test TEST_ARGS="-run TestJiraAlertList ./pkg/commands/ngwaf/workspace/alert/jira" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/jira   1.061s
make test TEST_ARGS="-run TestJiraAlertGet ./pkg/commands/ngwaf/workspace/alert/jira" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/jira   1.062s
make test TEST_ARGS="-run TestJiraAlertUpdate ./pkg/commands/ngwaf/workspace/alert/jira" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/jira   1.068s
make test TEST_ARGS="-run TestJiraAlertDelete ./pkg/commands/ngwaf/workspace/alert/jira" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/jira   1.054s

// mailinglist
make test TEST_ARGS="-run TestMailingListAlertCreate ./pkg/commands/ngwaf/workspace/alert/mailinglist" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/mailinglist    1.057s
make test TEST_ARGS="-run TestMailingListAlertList ./pkg/commands/ngwaf/workspace/alert/mailinglist" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/mailinglist    1.053s
 make test TEST_ARGS="-run TestMailingListAlertGet ./pkg/commands/ngwaf/workspace/alert/mailinglist" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/mailinglist    1.055s
make test TEST_ARGS="-run TestMailingListAlertUpdate ./pkg/commands/ngwaf/workspace/alert/mailinglist" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/mailinglist    1.050s
make test TEST_ARGS="-run TestMailingListAlertDelete ./pkg/commands/ngwaf/workspace/alert/mailinglist" 
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/mailinglist    1.052s

// microsoftteams
make test TEST_ARGS="-run TestMicrosoftTeamsAlertCreate ./pkg/commands/ngwaf/workspace/alert/microsoftteams"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/microsoftteams 1.051s
 make test TEST_ARGS="-run TestMicrosoftTeamsAlertList ./pkg/commands/ngwaf/workspace/alert/microsoftteams"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/microsoftteams 1.063s
make test TEST_ARGS="-run TestMicrosoftTeamsAlertGet ./pkg/commands/ngwaf/workspace/alert/microsoftteams"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/microsoftteams 1.059s
make test TEST_ARGS="-run TestMicrosoftTeamsAlertUpdate ./pkg/commands/ngwaf/workspace/alert/microsoftteams"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/microsoftteams 1.064s
make test TEST_ARGS="-run TestMicrosoftTeamsAlertDelete ./pkg/commands/ngwaf/workspace/alert/microsoftteams"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/microsoftteams 1.052s

// opsgenie
make test TEST_ARGS="-run TestOpsgenieAlertCreate ./pkg/commands/ngwaf/workspace/alert/opsgenie"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/opsgenie       1.055s
make test TEST_ARGS="-run TestOpsgenieAlertList ./pkg/commands/ngwaf/workspace/alert/opsgenie"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/opsgenie       1.059s
make test TEST_ARGS="-run TestOpsgenieAlertGet ./pkg/commands/ngwaf/workspace/alert/opsgenie"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/opsgenie       1.053s
make test TEST_ARGS="-run TestOpsgenieAlertUpdate ./pkg/commands/ngwaf/workspace/alert/opsgenie"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/opsgenie       1.068s
make test TEST_ARGS="-run TestOpsgenieAlertDelete ./pkg/commands/ngwaf/workspace/alert/opsgenie"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/opsgenie       1.056s

// pagerduty
make test TEST_ARGS="-run TestPagerDutyAlertCreate ./pkg/commands/ngwaf/workspace/alert/pagerduty"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/pagerduty      1.053s
make test TEST_ARGS="-run TestPagerDutyAlertList ./pkg/commands/ngwaf/workspace/alert/pagerduty"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/pagerduty      1.052s
make test TEST_ARGS="-run TestPagerDutyAlertGet ./pkg/commands/ngwaf/workspace/alert/pagerduty"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/pagerduty      1.065s
make test TEST_ARGS="-run TestPagerDutyAlertUpdate ./pkg/commands/ngwaf/workspace/alert/pagerduty"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/pagerduty      1.066s
 make test TEST_ARGS="-run TestPagerDutyAlertDelete ./pkg/commands/ngwaf/workspace/alert/pagerduty"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/pagerduty      1.058s

// slack
make test TEST_ARGS="-run TestSlackAlertCreate ./pkg/commands/ngwaf/workspace/alert/slack"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/slack  1.061s
make test TEST_ARGS="-run TestSlackAlertList ./pkg/commands/ngwaf/workspace/alert/slack"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/slack  1.058s
make test TEST_ARGS="-run TestSlackAlertGet ./pkg/commands/ngwaf/workspace/alert/slack"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/slack  1.059s
make test TEST_ARGS="-run TestSlackAlertUpdate ./pkg/commands/ngwaf/workspace/alert/slack"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/slack  1.063s
make test TEST_ARGS="-run TestSlackAlertDelete ./pkg/commands/ngwaf/workspace/alert/slack"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/slack  1.058s

// webhook
make test TEST_ARGS="-run TestWebhookAlertCreate ./pkg/commands/ngwaf/workspace/alert/webhook"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/webhook        1.058s
 make test TEST_ARGS="-run TestWebhookAlertList ./pkg/commands/ngwaf/workspace/alert/webhook"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/webhook        1.060s
make test TEST_ARGS="-run TestWebhookAlertGet ./pkg/commands/ngwaf/workspace/alert/webhook"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/webhook        1.065s
make test TEST_ARGS="-run TestWebhookAlertUpdate ./pkg/commands/ngwaf/workspace/alert/webhook"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/webhook        1.063s
make test TEST_ARGS="-run TestWebhookAlertDelete ./pkg/commands/ngwaf/workspace/alert/webhook"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/webhook        1.057s
--
make test TEST_ARGS="-run TestWebhookGetSigningKey ./pkg/commands/ngwaf/workspace/alert/webhook"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/webhook        1.063s
make test TEST_ARGS="-run TestWebhookRotateSigningKey ./pkg/commands/ngwaf/workspace/alert/webhook"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/alert/webhook        1.060s

@rcaril rcaril marked this pull request as ready for review December 1, 2025 19:04
@rcaril rcaril requested a review from a team as a code owner December 1, 2025 19:04
anthony-gomez-fastly
anthony-gomez-fastly reviewed Dec 1, 2025
View reviewed changes
rcaril and others added 2 commits December 2, 2025 09:20
@rcaril
Merge branch 'main' into rcaril/CDTOOL-1216-ngwaf-alerts-crud-support
5fe2404
@rcaril
Alert Common Refactor
1a24eac 
Restructured common references for alert types into root.go files. Common references stay in the alert root package, and individual attributes are moved to the root.go of the specific alert types.
@rcaril rcaril requested a review from kpfleming December 3, 2025 18:21
anthony-gomez-fastly
anthony-gomez-fastly reviewed Dec 3, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly reviewed Dec 3, 2025
View reviewed changes
kpfleming
kpfleming reviewed Dec 4, 2025
View reviewed changes
kpfleming
kpfleming reviewed Dec 4, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! TY!

@rcaril rcaril merged commit 0e669d1 into main Dec 8, 2025
18 of 21 checks passed
@rcaril rcaril deleted the rcaril/CDTOOL-1216-ngwaf-alerts-crud-support branch December 8, 2025 18:05
@BrewTestBot BrewTestBot mentioned this pull request Dec 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpfleming kpfleming kpfleming approved these changes

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rcaril @kpfleming @anthony-gomez-fastly