Add CRUD functionality for NGWAF lists #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

anthony-gomez-fastly merged 13 commits into main from CDTOOL-1219-ngwaf-lists

Nov 21, 2025

Contributor

anthony-gomez-fastly commented Nov 18, 2025 •

edited

Loading

Change summary

Allow users to perform CRUD operations

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

Does your submission pass tests?

Changes to Core Features:

Have you written new tests for your core changes, as applicable?
Have you successfully run tests with your changes locally?


          feat(commands/ngwaf/list): add CRUD functionality for NGWAF lists

6b2eace

anthony-gomez-fastly force-pushed the CDTOOL-1219-ngwaf-lists branch from 1947533 to 6b2eace Compare

November 20, 2025 22:01

anthony-gomez-fastly marked this pull request as ready for review

November 20, 2025 22:01

anthony-gomez-fastly requested a review from a team as a code owner

November 20, 2025 22:01

anthony-gomez-fastly requested review from kpfleming and rcaril

November 20, 2025 22:01

rcaril reviewed

View reviewed changes

pkg/commands/ngwaf/accountcountrylist/create.go Outdated Show resolved Hide resolved

rcaril reviewed

View reviewed changes

pkg/commands/ngwaf/accountcountrylist/create.go Outdated Show resolved Hide resolved


          remove extra input field and add hyphen to level descriptions

c0a29a1

anthony-gomez-fastly commented

View reviewed changes

pkg/commands/ngwaf/ngwaflist/api.go Show resolved Hide resolved

anthony-gomez-fastly requested a review from rcaril

November 21, 2025 14:24

rcaril reviewed

View reviewed changes

pkg/text/list.go Outdated Show resolved Hide resolved

rcaril reviewed

View reviewed changes

pkg/text/list.go Show resolved Hide resolved

anthony-gomez-fastly added 2 commits

November 21, 2025 11:08


          reorg v2

16da4e5


          typo

cdaa7fd

rcaril reviewed

View reviewed changes

pkg/commands/ngwaf/workspace/countrylist/list.go Show resolved Hide resolved

rcaril previously requested changes

View reviewed changes

Contributor

rcaril left a comment

Solid implementation, we just need to review the usage of OptionalWorkspaceID.

anthony-gomez-fastly added 2 commits

November 21, 2025 13:33


          add both created at and updated at for list prints

6ff3587


          remove required field from workspace id to make it not break

4ea7d89

anthony-gomez-fastly requested a review from rcaril

November 21, 2025 18:45

anthony-gomez-fastly added 2 commits

November 21, 2025 13:48


          Merge remote-tracking branch 'origin/main' into CDTOOL-1219-ngwaf-lists

b73b863


          remove unused error

64be13e

anthony-gomez-fastly dismissed rcaril’s stale review

November 21, 2025 18:50

made changes

rcaril approved these changes

View reviewed changes

Contributor

rcaril left a comment

A few typos, but otherwise looks good to me!

pkg/commands/ngwaf/workspace/iplist/create.go Outdated Show resolved Hide resolved

pkg/commands/ngwaf/workspace/stringlist/create.go Outdated Show resolved Hide resolved

pkg/commands/ngwaf/workspace/wildcardlist/create.go Outdated Show resolved Hide resolved

pkg/commands/ngwaf/workspace/countrylist/create.go Outdated Show resolved Hide resolved

pkg/commands/ngwaf/workspace/iplist/delete.go Show resolved Hide resolved

pkg/commands/ngwaf/workspace/countrylist/create.go Outdated Show resolved Hide resolved

anthony-gomez-fastly added 5 commits

November 21, 2025 14:21


          Revert "remove unused error"

bc65b10

This reverts commit 64be13e.


          fix typo

3a003dd


          fix other typo

41c877a


          update command names

e31fa22


          fix missing workspace error in tests

c81875e

anthony-gomez-fastly enabled auto-merge (squash)

November 21, 2025 20:35

anthony-gomez-fastly disabled auto-merge

November 21, 2025 20:35

anthony-gomez-fastly enabled auto-merge (squash)

November 21, 2025 20:35

anthony-gomez-fastly merged commit 751915d into main

13 checks passed

anthony-gomez-fastly deleted the CDTOOL-1219-ngwaf-lists branch

November 21, 2025 20:35

BrewTestBot mentioned this pull request

fastly 13.2.0 Homebrew/homebrew-core#258064

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet