Skip to content

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Aug 28, 2025

All Submissions:

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • New get command that only provides the value of a key
  • Updated the describe to now only provide the attributes of a key, rather than the value of a key itself

Are there any considerations that need to be addressed for release?

The following features are now supported:

Create:

  • add
  • append
  • prepend
  • metadata
  • if_generation_match
  • background_fetch

Delete

  • if_generation_match
  • force

Describe

  • if_generation_match
  • metadata

Get

  • if_generation_match

Tests:

 make test TEST_ARGS="-run TestCreateCommand ./pkg/commands/kvstoreentry/"
ok      github.com/fastly/cli/pkg/commands/kvstoreentry 1.105s

make test TEST_ARGS="-run TestGetCommand ./pkg/commands/kvstoreentry/"
ok      github.com/fastly/cli/pkg/commands/kvstoreentry 1.083s

 make test TEST_ARGS="-run TestDescribeCommand ./pkg/commands/kvstoreentry/"
ok      github.com/fastly/cli/pkg/commands/kvstoreentry 1.069s

make test TEST_ARGS="-run TestDeleteCommand ./pkg/commands/kvstoreentry/"
ok      github.com/fastly/cli/pkg/commands/kvstoreentry 1.103s

rcaril added 6 commits August 26, 2025 12:22
- The new get function will now be operating as the prior describe function.
- Encoded values in base64 for --verbose & --json
@rcaril rcaril requested a review from a team as a code owner August 28, 2025 21:00
@rcaril rcaril requested a review from philippschulte August 28, 2025 21:00
@rcaril
Copy link
Contributor Author

rcaril commented Aug 28, 2025

Will update CHANGELOG tomorrow.

Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a solid implementation. Please keep in mind that this introduces a breaking change for anyone who previously used fastly kv-store-entry describe -k foo -s bar to get the value. Please make sure to state it properly in the changelog. Please add the link to the docs in the PR description. Thank you!

Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes to make but overall this looks great!

rcaril and others added 2 commits September 10, 2025 12:16
Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
@rcaril rcaril requested a review from kpfleming September 10, 2025 16:37
@rcaril rcaril merged commit 784ef73 into main Sep 10, 2025
12 checks passed
@rcaril rcaril deleted the CDTOOL-1017 branch September 10, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants