-
Notifications
You must be signed in to change notification settings - Fork 71
feat(kvstoreentry): Support for missing CRUD attributes #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- The new get function will now be operating as the prior describe function. - Encoded values in base64 for --verbose & --json
|
Will update CHANGELOG tomorrow. |
philippschulte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is a solid implementation. Please keep in mind that this introduces a breaking change for anyone who previously used fastly kv-store-entry describe -k foo -s bar to get the value. Please make sure to state it properly in the changelog. Please add the link to the docs in the PR description. Thank you!
kpfleming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes to make but overall this looks great!
Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
getcommand that only provides thevalueof akeydescribeto now only provide the attributes of a key, rather than the value of a key itselfAre there any considerations that need to be addressed for release?
The following features are now supported:
Create:
Delete
Describe
Get
Tests: