-
Notifications
You must be signed in to change notification settings - Fork 71
feat(domain discovery): add support for Domain Discovery commands #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Integralist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks @FarhanSajid1
Just a couple of minor/nit comments and suggestions (approving to unblock).
kpfleming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor changes, otherwise this looks great! Nice work.
Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
All Submissions:
New Feature Submissions:
This PR adds commands for
toolsand adomainsubcommand. Thetoolscommand will be used for placing tools moving forward.Once a user has enabled Domain Discovery on their accounts, they should have access to the Domain Discovery endpoints.
The commands make use of the
statusandsuggestimplementation which were added in fastly/go-fastly#672.The core changes:
domains, which will be a child oftools.suggestandstatussubcommands under toolssuggestandstatussubcommandsChanges to Core Features:
User Impact
Users that have enabled domain discovery on their accounts can use the
suggestandstatuscommands.Usage:
Fastly Tools
Fastly Domain Tools
Status Usage:
Status Commands
Suggest Usage:
Suggest Commands
Are there any considerations that need to be addressed for release?
No breaking changes