[match][hotfix] remove the renew_expired_certs option introduced in #21691 and revert the default behavior while we address issues with it#21812
Merged
rogerluan merged 3 commits intoFeb 10, 2024
Conversation
6 tasks
rogerluan
requested changes
Jan 17, 2024
rogerluan
left a comment
Member
There was a problem hiding this comment.
Thanks for opening this PR, we need to carefully review whether we want to revert the feature (aka merge this PR) or merge your other one (that fixes it) 😬
Can you review my question below? 🙏
Contributor
Author
|
@rogerluan , sorry for the delay. Changed all to false and removed auto-renewal test. |
83173f3 to
6ba32a2
Compare
lacostej
approved these changes
Feb 9, 2024
renew_expired_certs option introduced in #21691 and revert the default behavior while we address issues with it
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Removes
renew_expired_certs#21691, but behavior stays the same.Doing this in favor of #21809, that doesn't require this option any more
Description
Testing Steps