[match] propagate keychain when installing wwdr certificates#21578
Merged
lacostej merged 5 commits intoJan 15, 2024
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
4aedf33 to
5dad6a5
Compare
5dad6a5 to
f065e6d
Compare
4 tasks
lacostej
reviewed
Dec 9, 2023
Contributor
Author
|
conflicts resolved, the CI failure is possibly due to #21663 |
rogerluan
approved these changes
Jan 14, 2024
rogerluan
left a comment
Member
There was a problem hiding this comment.
💪 LGTM! Simple and safe. Thanks for your contribution @rabbitinspace ! 🚀
Contributor
|
Yay no more changing default keychain :D thanks man |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
After updating from fastlane 2.202.0 to 2.216.0
fastlane match -s $KEYCHAIN -p $PASSWORDstarted to fail for me with the following error:I import wwdr certs manually after creating a keychain, so something is broken here. The weird thing I found is
security find-certificateis invoked for the login keychain despite me specifying a separate one. After digging a bit, I figured theinstall_missing_wwdr_certificatesmethod doesn't take into account the-soption.Description
This PR makes the
-soption to be propagated to theinstall_missing_wwdr_certificatesmethod instead of unconditionally usingwwdr_keychain. I found this issue which supposed to be fixed, but I guess this edge case isn't handled.Also, I hope I fixed the tests the right way.
Testing Steps