build(.github): pin actions to commit-hash #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
reviewed
Mar 20, 2025
RafaelGSS
approved these changes
Mar 21, 2025
Member
RafaelGSS
left a comment
There was a problem hiding this comment.
FWIW dependabot and renovatebot automatically update those dependencies in the same way as git tags.
Member
Author
That's fine as this repo doesn't automerge dependabot updates, so someone will now need to manually review and merge, adding an extra layer of security. :) |
gurgunday
reviewed
Mar 23, 2025
Member
|
I am not blocking this. But I am having a hard time understanding the difference between using tags for GitHub maintained actions and letting Dependabot update the hashes automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After what has been happening with tj-actions/changed-files over the past week this is probably a sensible idea.
@RafaelGSS even wrote about it a while back!
Checklist
and the Code of conduct