feat: add an overload function to parse#95
Merged
mcollina merged 2 commits intofastify:masterfrom Apr 7, 2023
Merged
Conversation
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Contributor
Author
Sure |
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Eomm
approved these changes
Apr 7, 2023
Member
|
I can't release it due to permission |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an overload function type to
parsewhich provides a better developer experience and makes typescript happyBy adding an overload, we don't have to use
@ts-expect-errorflag, when only 2 arguments are passed toparselike in this exampleChecklist
npm run testandnpm run benchmarkand the Code of conduct