Skip to content

move types to types folder#80

Merged
Uzlopak merged 1 commit intofastify:masterfrom
Uzlopak:move-types
Jul 29, 2022
Merged

move types to types folder#80
Uzlopak merged 1 commit intofastify:masterfrom
Uzlopak:move-types

Conversation

@Uzlopak
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak commented Jul 29, 2022

small change to make the project more structured

Checklist

@Uzlopak Uzlopak requested a review from climba03003 July 29, 2022 10:54
@@ -1,5 +1,5 @@
import { expectType, expectError } from 'tsd'
import sjson = require('.')
import sjson from '..'
Copy link
Copy Markdown
Member

@climba03003 climba03003 Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why import sjson = require('.') to import sjson from '.'? - Question only

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a TS 1202 Error

image

So I thought: Why not.

@Uzlopak Uzlopak merged commit 5798ff9 into fastify:master Jul 29, 2022
@Uzlopak Uzlopak deleted the move-types branch July 29, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants