move tests to test folder, refactor tests to implicitly test scan()#79
Merged
Uzlopak merged 2 commits intofastify:masterfrom Jul 29, 2022
Merged
move tests to test folder, refactor tests to implicitly test scan()#79Uzlopak merged 2 commits intofastify:masterfrom
Uzlopak merged 2 commits intofastify:masterfrom
Conversation
refactor tests to implicitly test scan()
climba03003
requested changes
Jul 29, 2022
Co-authored-by: KaKa <climba03003@gmail.com>
climba03003
approved these changes
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the tests so that they implicitly test for scan(). This is useful, if we decide to drop exporting scan() in a major release.
Checklist
npm run testandnpm run benchmarkand the Code of conduct