Skip to content

add safeParse to benchmarks#73

Merged
Uzlopak merged 5 commits intofastify:masterfrom
Uzlopak:add-benchmark
Jul 28, 2022
Merged

add safeParse to benchmarks#73
Uzlopak merged 5 commits intofastify:masterfrom
Uzlopak:add-benchmark

Conversation

@Uzlopak
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak commented Jul 28, 2022

Checklist

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Jul 28, 2022

@mcollina

Somehow legacy tests fail. I assume because we did not pin tsd

Copy link
Copy Markdown
Contributor Author

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont merge yet

@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Jul 28, 2022

I merge it as the ci cd pipeline works now properly and I got an approval ;)

@Uzlopak Uzlopak merged commit 397ac6d into fastify:master Jul 28, 2022
@Uzlopak Uzlopak deleted the add-benchmark branch July 28, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants