Merged
Conversation
mcollina
requested changes
Apr 2, 2021
Member
mcollina
left a comment
There was a problem hiding this comment.
Could you add a test test for the types using tsd?
Contributor
Author
|
yep--turns out i made a mistake in the declarations the first time round! should be accurate now. |
Contributor
Author
|
looks like tsd doesn't support <10.x (even the versions that claim to support 8.x pull in dependencies that no longer do). |
Member
|
good for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds typescript types for the
secure-json-parsefunctions.The
anyreturn types are not ideal (it could be better to returnunknownand force an explicit cast) but this way it's the same asJSON.parse().Checklist
npm run testandnpm run benchmarkand the Code of conduct