Skip to content

Add createDeprecation method#87

Merged
jsumners merged 1 commit intomasterfrom
support-deprecation-warnings
Oct 27, 2023
Merged

Add createDeprecation method#87
jsumners merged 1 commit intomasterfrom
support-deprecation-warnings

Conversation

@jsumners
Copy link
Member

@jsumners jsumners commented Oct 27, 2023

I was looking through the documentation while reviewing another PR this morning and discovered that we do not provide a mechanism to support Node's extended support for deprecation warning. Namely, we don't provide a way to create a deprecation warning that can be traced with --trace-deprecation, thrown with --throw-deprecation, or silenced with --no-deprecation. So I decided to add it in as bonus functionality.

While I was at it, I fixed the lack of jsdoc.

Checklist

@jsumners jsumners force-pushed the support-deprecation-warnings branch from 7cdd1bb to 850ff68 Compare October 27, 2023 13:31
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners jsumners force-pushed the support-deprecation-warnings branch from 850ff68 to 3be4cb3 Compare October 27, 2023 13:35
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the jsdoc.

Means we will expect a follow up PR for fastify?

@jsumners jsumners merged commit 5c8ed1f into master Oct 27, 2023
@jsumners jsumners deleted the support-deprecation-warnings branch October 27, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants