use tap instead of ava, 100% test coverage, move types to types folder, activate linting in ci-pipeline#65
Merged
mcollina merged 6 commits intofastify:masterfrom Aug 18, 2022
Merged
Conversation
Fdawgs
reviewed
Aug 18, 2022
Member
Fdawgs
left a comment
There was a problem hiding this comment.
Don't know enough about tap to approve that bit, but the rest LGTM.
Contributor
Author
|
The only big change of the tap conversion was that ava has this test.serial.cb functionality, which basically spawns a new process for the unit test. This is relevant because we are listening in those two tests on process-events. If the tests run in parallel, then the tests fail, because we are listening on all events. Tap does not have this convenient way to run subtests in an own process. But you just have to extract the subtest to a separate suite and it runs in a separate process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct