fix: preserve query string when stripping path prefix#249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
app.use('/prefix', fn), the query string is stripped fromreq.urlbefore it reaches the middleware.This is a regression introduced in v9.2.0 by the GHSA-8p85-9qpw-fwgw fix.
normalizedReqUrlis derived fromnormalizePathForMatching()which callsFindMyWay.sanitizeUrlPath()— this removes query strings. Whenreq.urlis rebuilt by stripping the matched prefix fromnormalizedReqUrl, the query string is already gone.This fix preserves the query string suffix from the original
req.urland re-appends it after prefix stripping.Closes #248
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct