Skip to content

Rename module#148

Merged
RafaelGSS merged 2 commits intomasterfrom
rename-module
Jun 7, 2022
Merged

Rename module#148
RafaelGSS merged 2 commits intomasterfrom
rename-module

Conversation

@RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Jun 6, 2022

This pull request renames the module according to the discussion in
fastify/fastify#3733.

Note that the deprecation module has already been published and that the
code for it does not exist in this repository. The code for the published
deprecation module was generated by https://github.com/fastify/deprecate-modules
and run on @RafaelGSS local system.

Coordinating the drastic changes to the code for the module deprecation and
then restoring the code for the module renaming would have been extremely
difficult and prohibitively tedious.

Important: no further releases should be added to the old major version.

This commit renames the module in accordance with the discussion in
fastify/fastify/issues/3733 .
@RafaelGSS
Copy link
Member Author

RafaelGSS commented Jun 6, 2022

I don't have permission to publish the deprecation update to this package. Could someone give me access?

@Fdawgs
Copy link
Member

Fdawgs commented Jun 6, 2022

Could you update the readme as well please? 😊

Edit: And the plugin name, please?

name: 'middie'

@RafaelGSS
Copy link
Member Author

I don't have permission to publish the deprecation update to this package. Could someone give me access?

cc: @fastify/plugins

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners
Copy link
Member

jsumners commented Jun 7, 2022

I don't have permission to publish the deprecation update to this package. Could someone give me access?

cc: @fastify/plugins

I am unable to do this. Only @delvedor and @mcollina have maintainership of middie on npmjs.com. If I'm added, I'll get it imported to the org and the plugins team.

@mcollina
Copy link
Member

mcollina commented Jun 7, 2022

Done

@jsumners
Copy link
Member

jsumners commented Jun 7, 2022

@RafaelGSS you should now be able to publish middie and @fastify/middie.

@RafaelGSS
Copy link
Member Author

Thanks!

@RafaelGSS RafaelGSS merged commit c1f3722 into master Jun 7, 2022
@Fdawgs Fdawgs deleted the rename-module branch June 7, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants